Fixed issue #325 #585
Fixed issue #325 #585
Conversation
scripts/globals/weaponskills.lua
Outdated
| if (tp < 1000) then | ||
| tp = 1000 | ||
| end | ||
| --if (tp < 1000) then |
There was a problem hiding this comment.
If these aren't being used anymore, they can just be deleted 👍
There was a problem hiding this comment.
I think the intent was to floor at the minimum tp you could have in order to ws "just in case" some server decided to let you ws with less. I have no idea if thats even a problem but if it is I think that should be taken care of by whoever is customizing :)
There was a problem hiding this comment.
And I believe it's not a necessary check either, as this function defaults to returning an ftp of 1 for invalid TP values anyway.
So I support the outright removal of the comment parts, @Xlaits ! 👍
scripts/globals/weaponskills.lua
Outdated
| if (tp < 1000) then | ||
| tp = 1000 | ||
| end | ||
| --if (tp < 1000) then |
There was a problem hiding this comment.
And I believe it's not a necessary check either, as this function defaults to returning an ftp of 1 for invalid TP values anyway.
So I support the outright removal of the comment parts, @Xlaits ! 👍
|
Awesome. Forgot to remove commented code when pushing the comit initially.
…On Tue, May 12, 2020, 12:54 PM ibm2431 ***@***.***> wrote:
***@***.**** approved this pull request.
Pushed a commit that removed the previous commented lines! Approved.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#585 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHX2YDP6EO3JW562ZKWGZ73RRF5LPANCNFSM4MZARMOA>
.
|
I affirm: